Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Create new file with %edit magic (IPython console) #17181

Merged
merged 4 commits into from
Feb 17, 2022
Merged

PR: Create new file with %edit magic (IPython console) #17181

merged 4 commits into from
Feb 17, 2022

Conversation

impact27
Copy link
Contributor

Description of Changes

When using edit magic on a non-existing file, this creates a new file instead of doing nothing.

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #3394

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@impact27 impact27 changed the base branch from master to 5.x January 14, 2022 10:18
@impact27 impact27 closed this Jan 14, 2022
@impact27 impact27 reopened this Jan 14, 2022
ccordoba12
ccordoba12 reviewed Jan 17, 2022
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea @impact27! Thanks for looking into it.

spyder/plugins/ipythonconsole/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/widgets/main_widget.py Show resolved Hide resolved
@ccordoba12 ccordoba12 added this to the v5.3.0 milestone Jan 17, 2022
@ccordoba12
Copy link
Member

Hey @impact27, could you finish this PR? I think it's a great improvement and I'd like to include it in 5.3

ccordoba12
ccordoba12 approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27! This is a great UX enhancement!

@ccordoba12 ccordoba12 changed the title PR: Create new file with %edit magic PR: Create new file with %edit magic (IPython console) Feb 17, 2022
@ccordoba12 ccordoba12 merged commit c96b5ff into spyder-ide:5.x Feb 17, 2022
ccordoba12 added a commit that referenced this pull request Feb 17, 2022
@ccordoba12
Merge from 5.x: PR #17181
eb71463 
Fixes #3394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@impact27 impact27

Labels
None yet
Projects
None yet
Milestone
v5.3.0
Development

Successfully merging this pull request may close these issues.

%edit magic can't create a new file
2 participants
@impact27 @ccordoba12