PR: Update Windows installer assets URL to add previous installation validation #17209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a screenshot to the description above to see how this new functionality looks? |
|
Thanks @dalthviz! What happens if the user clicks |
|
Yes, the installation process exits @ccordoba12 |
|
Ok, great! That's what I'd like to enforce too, but I wanted to check with you before proceeding. |
dalthviz
changed the title
dalthviz
changed the title
ccordoba12
approved these changes
Jan 19, 2022
ccordoba12
added a commit
that referenced
this pull request
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds a validation for previous installations with the Windows installer. Before launching the installer a validation for an old installation is run. If an old installation is detected a messagebox appears to ask the users if they want to launch the uninstaller:
Clicking Sí/Yes:
Depends on spyder-ide/windows-installer-assets#6 and a new release (0.0.5)
Note: After the uninstall the installer needs to be relaunched to do the install
Issue(s) Resolved
Fixes #17025
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: dalthviz