Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Test that the debugger handles the namespace of a comprehension #17231

Merged
merged 5 commits into from
Jan 25, 2022

Conversation

impact27
Copy link
Contributor

@impact27 impact27 commented Jan 22, 2022

Description of Changes

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

Quentin Peter added 2 commits January 22, 2022 08:39
…thub.com/impact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "0b370e763"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "comprehension_namespace"
  commit:   "0b370e763"
git-subrepo:
  version:  "0.4.1"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "a04d8c2"
@impact27 impact27 changed the title Test comprehension namespace PR: Test comprehension namespace Jan 24, 2022
@ccordoba12 ccordoba12 changed the title PR: Test comprehension namespace PR: Test that the debugger handles the namespace of a comprehension Jan 25, 2022
@ccordoba12
Copy link
Member

This looks ready too, so I'll merge the corresponding PR in spyder-kernels and resync the subrepo here before merging.

…der-ide/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "7478e8501"
upstream:
  origin:   "https://github.com/spyder-ide/spyder-kernels.git"
  branch:   "2.x"
  commit:   "7478e8501"
git-subrepo:
  version:  "0.4.3"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "2f68596"

[ci skip]
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27!

@ccordoba12 ccordoba12 added this to the v5.3.0 milestone Jan 25, 2022
@ccordoba12 ccordoba12 merged commit dd3824c into spyder-ide:5.x Jan 25, 2022
ccordoba12 added a commit that referenced this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants