Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Make context run cell icons match run menu icons #17510

Merged
merged 1 commit into from
Mar 18, 2022
Merged

PR: Make context run cell icons match run menu icons #17510

merged 1 commit into from
Mar 18, 2022

Conversation

rhkarls
Copy link
Contributor

@rhkarls rhkarls commented Mar 18, 2022

Description of Changes

Minor change to the icons of the context menu to make them consistent and match that of the Run menu.

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

The run menu icons for running cell code looks like this, with different icon for Run cell and Run cell and advance and no icon for Re-run last cell.
run_menu

The context menu on 5.3.0.dev0 looks like this, with the Run cell icon repeated for Run cell and advance and Re-run last cell.
run_context_pre

This PR sets the proper icon for Run cell and advance and removes Re-run last cell on the context menu, so that it is consistent with the Run menu.
run_context_post

Issue(s) Resolved

No issue opened

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @rhkarls

@rhkarls rhkarls changed the title context run cell icons match run menu icons PR: Make context run cell icons match run menu icons Mar 18, 2022
@dalthviz dalthviz added this to the v5.3.0 milestone Mar 18, 2022
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rhkarls for noticing this and submitting a fix! LGTM 👍

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rhkarls for your help with this!

@ccordoba12 ccordoba12 merged commit e34ef82 into spyder-ide:5.x Mar 18, 2022
ccordoba12 added a commit that referenced this pull request Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants