Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix setting max line length for Black (Completions) #17567

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

ccordoba12
Copy link
Member

Description of Changes

  • This was not working due to the lack of client-side options to configure python-lsp-black, which were added in its 1.2.0 version.
  • Also set other configuration options added in that version.

Issue(s) Resolved

Fixes #14558

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@ccordoba12 ccordoba12 self-assigned this Mar 29, 2022
@ccordoba12 ccordoba12 added this to the v5.3.0 milestone Mar 29, 2022
Also set other configuration options added in python-lsp-black
1.2.0
@pep8speaks
Copy link

pep8speaks commented Mar 29, 2022

Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-03-29 16:27:52 UTC

Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccordoba12 ! LGTM 👍

@dalthviz dalthviz merged commit 547a886 into spyder-ide:5.x Mar 29, 2022
dalthviz added a commit that referenced this pull request Mar 29, 2022
@ccordoba12 ccordoba12 deleted the issue-14558 branch March 29, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants