PR: Revise run_python_script_in_terminal #17635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quote wdir for darwin in write statement. Fix typo for PYTHONHOME environment variable. For Terminal.app, env and cwd kwargs in Popen do not have any affect.
Do not 'cd' in cmd as this is redundant with cwd keyword argument.
remove wdir-option as it is redundant with cwd. run_program does not like quoted python file, whereas run_shell_command is okay with it.
ccordoba12
reviewed
Apr 7, 2022
There was a problem hiding this comment.
Thanks for your help with this @mrclary! I left a small question for you, otherwise looks good to me.
|
@ccordoba12 @dalthviz, I neglected to mention that I successfully tested the behavior on macOS, Ubuntu (VM), and Windows (VM). Just an FYI; please do verify as well, if you can. |
ccordoba12
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
run_python_script_in_terminalis revised to:wdirand/or python file pathIssue(s) Resolved
Fixes #17595
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @mrclary