Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Subscribe to configs for Matplotlib inline backend (IPython Console) #17767

Merged
merged 3 commits into from
Apr 28, 2022

Conversation

dalthviz
Copy link
Member

Description of Changes

Some Matplotlib options where being ignored since no method was subscribed to their changes

Issue(s) Resolved

Fixes #16297

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz for this! I left a minor stylistic option for you, otherwise looks good to me.

spyder/plugins/ipythonconsole/widgets/main_widget.py Outdated Show resolved Hide resolved
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to me now, thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit ebc2587 into spyder-ide:5.x Apr 28, 2022
ccordoba12 added a commit that referenced this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants