PR: Add missing PyQtWebEngine dependency for conda-forge based CI and fix tests
#17860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
force-pushed
the
conda-forge-pyqt-update
branch
from
bf429ca
to
8fa7a10
Compare
dalthviz
force-pushed
the
conda-forge-pyqt-update
branch
from
8fa7a10
to
d3b3581
Compare
Fix RuntimeError when running linux file tests due to multiple calls to spyder.utils.qthelpers.qapplication
dalthviz
force-pushed
the
conda-forge-pyqt-update
branch
from
d3b3581
to
ad23e03
Compare
dalthviz
changed the title
PyQtWebEngine dependency for conda-forge based CI
dalthviz
changed the title
PyQtWebEngine dependency for conda-forge based CIPyQtWebEngine dependency for conda-forge based CI and fix tests
Closed
ccordoba12
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
With PyQt 5.15.4 available on conda-forge, we also need to require PyQtWebEngine 5.15.4 (for our tests when installing on conda-forge)
Also, with the new version available on conda-forge some tests started failing
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: dalthviz