Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add openpyxl and defusedxml to the full version Windows installers #18105

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Jun 1, 2022

Description of Changes

Adds a optional dependency (openpyxl) to handle Excel files with pandas to the Windows installer that comes with pandas. Also adds defusedxml following the openpyxl security warning: https://openpyxl.readthedocs.io/en/stable/#security

Issue(s) Resolved

Part of #18071

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@dalthviz dalthviz added this to the v5.3.2 milestone Jun 1, 2022
@dalthviz dalthviz requested a review from ccordoba12 June 1, 2022 15:50
@dalthviz dalthviz self-assigned this Jun 1, 2022
@dalthviz dalthviz changed the title PR: Add 'openpyxl' and 'defusedxml' to the full version Windows installers PR: Add openpyxl and defusedxml to the full version Windows installers Jun 1, 2022
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit 5c30318 into spyder-ide:5.x Jun 1, 2022
ccordoba12 added a commit that referenced this pull request Jun 1, 2022
@dalthviz dalthviz mentioned this pull request Jun 29, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants