PR: test_sympy_client xpasses with sympy version 1.10.1
#18108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
changed the title
test_sympy_client xpasses with sympy version 1.10.1
|
Hey @juliangilbey, thanks for your help with this! Right now @dalthviz is working to fix our tests in another PR. When that's done, we'll ask you to rebase this one. |
|
Hi @juliangilbey please rebase your branch on top of the latest 5.x to fix the tests. Thanks again for your help checking the tests suite and let us know if you need any help with the rebase |
juliangilbey
force-pushed
the
test_sympy_version_check
branch
from
b87ccf5
to
932039e
Compare
|
Rebased as requested! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The current version of sympy (at least in Debian) is 1.10.1, so
test_sympy_clientxpasses. This patch does a correct version number check in thexfailmarker. A simpler alternative, since sympy 1.2 was released about 4 years ago, is just to remove thexfailmarker entirely.Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
Julian Gilbey @juliangilbey