Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix issue where nbconvert was not importable in macOS application #18278

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Jun 13, 2022

defusedxml was already a dependency of nbconvert, so it was redundent to include in the scientific packages list for the full version, but this also caused it to be explicitly excluded for the lite version, hence the issue for nbconvert.

Related to #18106

defusedxml was already a dependency of nbconvert, so when it was redundent to include in the scientific packages list for the full version, but this also caused it to be explicitly excluded for the lite version, hence the issue for nbconvert.
@mrclary mrclary self-assigned this Jun 13, 2022
@ccordoba12 ccordoba12 added this to the v5.3.2 milestone Jun 13, 2022
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary! I'm going to merge this one so that @dalthviz can pick it up on PR #18106.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants