Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add constraint on numpy <1.23 to solve tests #18412

Closed
wants to merge 2 commits into from

Conversation

impact27
Copy link
Contributor

Description of Changes

solves #18407

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@pep8speaks
Copy link

Hello @impact27! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 253:80: E501 line too long (94 > 79 characters)

@dalthviz dalthviz added this to the v5.3.2 milestone Jun 23, 2022
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your quick help to solve this problem @impact27! This looks good to me but what we usually do to solve problems like these is not to alter our dependencies because they will be eventually solved. In this case, I think Numpy developers will be informed about the lack of completions and they'll soon release 1.23.1.

Instead, we prefer to install older versions of the packages that are failing here:

https://github.com/spyder-ide/spyder/blob/master/.github/scripts/install.sh

That's the installation script we use for Github actions. So, by requiring Numpy 1.22 there our tests will run without problems too.

So, my advice is to revert the changes you did and only modify install.sh. Let us know if that's fine for you or you prefer for me to do it in another PR.

@impact27
Copy link
Contributor Author

You can do it in another PR

@impact27 impact27 closed this Jun 23, 2022
@ccordoba12 ccordoba12 removed this from the v5.3.2 milestone Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants