Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Escape hyphen from update instructions for spyder-kernels (IPython Console) #18471

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

dalthviz
Copy link
Member

Description of Changes

Use ‐ instead of plain - to prevent copy-pasting an incorrect command following kernel instructions to update

Pinging @jnsebgosselin just in case to check if another approach for this was found

Issue(s) Resolved

Fixes #17425

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@jnsebgosselin
Copy link
Member

This seems like a very good solution! Thank you for the fix, this is going to make my life easier.

@jnsebgosselin
Copy link
Member

jnsebgosselin commented Jun 28, 2022

I've tested locally and it does not solve the problem on my setup unfortunately. The hyphen still get replaced by a non-breaking hypen when copied to the clipboard.

@jnsebgosselin
Copy link
Member

@dalthviz
Copy link
Member Author

Seems like now the code is the correct one, no? I think for hyphen the code is &#x2010 while for non-breaking-hyphen is &#x2011 However, even with that the command is not working for you then 🤔 ?

Something else I was thinking about is that probably we need to add the -c conda-forge part since the anaconda default channel goes just up to spyder-kernels 2.2.1

@jnsebgosselin
Copy link
Member

Oh yeah, you are right. &#x2010 is the code for the normal hyphen. It is still not working in the Windows cmd though. I still need to replace the &#x2010 (0x2010) with a normal - (0x2d).

image

@dalthviz
Copy link
Member Author

Could you try using -?

@jnsebgosselin
Copy link
Member

Yes, it works with -.

I thought it was either the pre or tt environment that was causing the issue, but it seems it is something else because I tried without these and the hyphen was still replaced by a non-breaking hyphen. Anyway, it does not matter since you seem to have found a good working solution, thanks!

@jnsebgosselin
Copy link
Member

image

@dalthviz
Copy link
Member Author

Awesome! Thanks for the help checking this @jnsebgosselin !

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ccordoba12 ccordoba12 merged commit bed2be5 into spyder-ide:5.x Jun 28, 2022
ccordoba12 added a commit that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants