PR: Improve update UX and automatically download latest installers

spyder/plugins/application/container.py

@@ -21,13 +21,15 @@
 from qtpy.QtWidgets import QAction, QMessageBox, QPushButton
 
 # Local imports
-from spyder import __docs_url__, __forum_url__, __trouble_url__
+from spyder import __docs_url__, __forum_url__, __trouble_url__, __version__
 from spyder import dependencies
 from spyder.api.translations import get_translation
 from spyder.api.widgets.main_container import PluginMainContainer
 from spyder.utils.installers import InstallerMissingDependencies
 from spyder.config.utils import is_anaconda
-from spyder.config.base import get_conf_path, get_debug_level
+from spyder.config.base import (get_conf_path, get_debug_level, is_pynsist,
+                                running_in_mac_app)
+from spyder.plugins.application.widgets.status import ApplicationUpdateStatus
 from spyder.plugins.console.api import ConsoleActions
 from spyder.utils.qthelpers import start_file, DialogManager
 from spyder.widgets.about import AboutDialog
@@ -99,6 +101,13 @@ def __init__(self, name, plugin, parent=None):
     # ---- PluginMainContainer API
     # -------------------------------------------------------------------------
     def setup(self):
+
+        self.application_update_status = ApplicationUpdateStatus(parent=self)
+        self.application_update_status.sig_check_for_updates_requested.connect(
+            self.check_updates
+        )
+        self.application_update_status.set_no_status()
+
         # Compute dependencies in a thread to not block the interface.
         self.dependencies_thread = QThread(None)
 
@@ -235,6 +244,7 @@ def show_windows_env_variables(self):
 
     # ---- Updates
     # -------------------------------------------------------------------------
+
     def _check_updates_ready(self):
         """Show results of the Spyder update checking process."""
 
@@ -278,11 +288,16 @@ def _check_updates_ready(self):
             box.exec_()
             check_updates = box.is_checked()
         else:
+
             if update_available:
-                header = _("<b>Spyder {} is available!</b><br><br>").format(
-                    latest_release)
+                self.application_update_status.set_status_pending(
+                    latest_release=latest_release)
+
+                header = _("<b>Spyder {} is available!</b> "
+                           "<i>(you have {})</i><br><br>").format(
+                    latest_release, __version__)
                 footer = _(
-                    "For more information visit our "
+                    "For more information, visit our "
                     "<a href=\"{}\">installation guide</a>."
                 ).format(url_i)
                 if is_anaconda():
@@ -296,23 +311,35 @@ def _check_updates_ready(self):
                         "<code>conda update anaconda</code><br>"
                         "<code>conda install spyder={}</code><br><br>"
                     ).format(latest_release)
-                else:
+                elif is_pynsist() or running_in_mac_app():
+                    box.setStandardButtons(QMessageBox.Yes |
+                                           QMessageBox.No)
                     content = _(
-                        "Click <a href=\"{}\">this link</a> to "
-                        "download it.<br><br>"
-                    ).format(url_r)
+                        "Would you like to automatically download and "
+                        "install it?<br><br>"
+                    )
+
                 msg = header + content + footer
                 box.setText(msg)
                 box.set_check_visible(True)
-                box.show()
+                box.exec_()
+
+                if box.result() == QMessageBox.Yes:
+                    self.application_update_status.start_installation(
+                        latest_release=latest_release)
+                elif(box.result() == QMessageBox.No):
+                    self.application_update_status.set_status_pending(
+                        latest_release=latest_release)
                 check_updates = box.is_checked()
             elif feedback:
                 msg = _("Spyder is up to date.")
                 box.setText(msg)
                 box.set_check_visible(False)
                 box.exec_()
                 check_updates = box.is_checked()
-
+                self.application_update_status.set_no_status()
+            else:
+                self.application_update_status.set_no_status()
         # Update checkbox based on user interaction
         self.set_conf(option, check_updates)
 
@@ -327,6 +354,7 @@ def check_updates(self, startup=False):
         """Check for spyder updates on github releases using a QThread."""
         # Disable check_updates_action while the thread is working
         self.check_updates_action.setDisabled(True)
+        self.application_update_status.set_status_checking()
 
         if self.thread_updates is not None:
             self.thread_updates.quit()

spyder/plugins/application/plugin.py

@@ -43,7 +43,7 @@ class Application(SpyderPluginV2):
     NAME = 'application'
     REQUIRES = [Plugins.Console, Plugins.Preferences]
     OPTIONAL = [Plugins.Help, Plugins.MainMenu, Plugins.Shortcuts,
-                Plugins.Editor]
+                Plugins.Editor, Plugins.StatusBar]
     CONTAINER_CLASS = ApplicationContainer
     CONF_SECTION = 'main'
     CONF_FILE = False
@@ -101,7 +101,20 @@ def on_editor_available(self):
         editor = self.get_plugin(Plugins.Editor)
         self.get_container().sig_load_log_file.connect(editor.load)
 
+    @on_plugin_available(plugin=Plugins.StatusBar)
+    def on_statusbar_available(self):
+        # Add status widget
+        statusbar = self.get_plugin(Plugins.StatusBar)
+        statusbar.add_status_widget(self.application_update_status)
+
     # -------------------------- PLUGIN TEARDOWN ------------------------------
+
+    @on_plugin_teardown(plugin=Plugins.StatusBar)
+    def on_statusbar_teardown(self):
+        # Remove status widget
+        statusbar = self.get_plugin(Plugins.StatusBar)
+        statusbar.remove_status_widget(self.application_update_status.ID)
+
     @on_plugin_teardown(plugin=Plugins.Preferences)
     def on_preferences_teardown(self):
         preferences = self.get_plugin(Plugins.Preferences)
@@ -443,3 +456,7 @@ def report_action(self):
     def debug_logs_menu(self):
         return self.get_container().get_menu(
             ApplicationPluginMenus.DebugLogsMenu)
+
+    @property
+    def application_update_status(self):
+        return self.get_container().application_update_status

spyder/plugins/application/widgets/__init__.py

@@ -0,0 +1,8 @@
+# -*- coding: utf-8 -*-
+#
+# Copyright © Spyder Project Contributors
+#
+# Licensed under the terms of the MIT License
+# (see spyder/__init__.py for details)
+
+"""Widgets for the Application plugin."""