Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Patch rpath in micromamba so that code signing doesn't break it #18685

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Jul 15, 2022

Description of Changes

Remove @rpath reference in @rpath/libc++.1.dylib in the micromamba executable to be compliant with runtime hardening.

Issue(s) Resolved

Fixes #18661

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @mrclary

@mrclary mrclary self-assigned this Jul 15, 2022
@mrclary mrclary requested a review from ccordoba12 July 15, 2022 16:59
@mrclary mrclary added this to the v5.3.3 milestone Jul 15, 2022
ccordoba12
ccordoba12 previously approved these changes Jul 15, 2022
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary!

@ccordoba12 ccordoba12 changed the base branch from master to 5.x July 15, 2022 17:17
@ccordoba12 ccordoba12 dismissed their stale review July 15, 2022 17:17

The base branch was changed.

@ccordoba12 ccordoba12 merged commit d6dc36c into spyder-ide:5.x Jul 15, 2022
ccordoba12 added a commit that referenced this pull request Jul 15, 2022
@mrclary mrclary deleted the fix-issue-18661-micromamba branch July 19, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code signature breaks micromamba in macOS application
2 participants