Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Prevent segfault when modifying the editor content #18686

Merged
merged 5 commits into from
Jul 20, 2022
Merged

PR: Prevent segfault when modifying the editor content #18686

merged 5 commits into from
Jul 20, 2022

Conversation

impact27
Copy link
Contributor

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Try to detect when a block becomes invalid

Issue(s) Resolved

Fixes #18520

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@pep8speaks
Copy link

pep8speaks commented Jul 15, 2022 •
edited
Loading

Hello @impact27! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-07-20 17:04:53 UTC

@impact27 impact27 changed the base branch from master to 5.x July 15, 2022 18:35
@impact27 impact27 changed the title PR: Check block safety PR: Prevent segfault when modyfiing the editor content Jul 20, 2022
@impact27 impact27 changed the title PR: Prevent segfault when modyfiing the editor content PR: Prevent segfault when modyfying the editor content Jul 20, 2022
@impact27 impact27 changed the title PR: Prevent segfault when modyfying the editor content PR: Prevent segfault when modifying the editor content Jul 20, 2022
ccordoba12
ccordoba12 reviewed Jul 20, 2022
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27 for your help with this!

spyder/plugins/editor/utils/editor.py Outdated Show resolved Hide resolved
spyder/plugins/editor/utils/editor.py Outdated Show resolved Hide resolved
spyder/plugins/editor/utils/editor.py Outdated Show resolved Hide resolved
spyder/plugins/editor/utils/editor.py Outdated Show resolved Hide resolved
spyder/plugins/editor/widgets/codeeditor.py Show resolved Hide resolved
spyder/plugins/editor/widgets/codeeditor.py Show resolved Hide resolved
@ccordoba12 ccordoba12 added this to the v5.3.3 milestone Jul 20, 2022
@impact27
Copy link
Contributor Author

#16396 removed part of the previous mitigation. Because the rest should not help, it is removed as well.

ccordoba12
ccordoba12 approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27!

@ccordoba12 ccordoba12 merged commit b568c18 into spyder-ide:5.x Jul 20, 2022
ccordoba12 added a commit that referenced this pull request Jul 20, 2022
@ccordoba12
Merge from 5.x: PR #18686
4f331a8 
Fixes #18520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@impact27 impact27

Labels
None yet
Projects
None yet
Milestone
v5.3.3
Development

Successfully merging this pull request may close these issues.

Segmentation fault crash from the Editor
3 participants
@impact27 @pep8speaks @ccordoba12