Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Make style of "Print preview" dialog follow the rest of Spyder #18869

Merged
merged 3 commits into from
Aug 1, 2022

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Jul 30, 2022

Description of Changes

Before

imagen

After

imagen

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@ccordoba12 ccordoba12 added this to the v5.3.3 milestone Jul 30, 2022
@ccordoba12 ccordoba12 requested a review from dalthviz July 30, 2022 00:42
@ccordoba12 ccordoba12 self-assigned this Jul 30, 2022
@pep8speaks
Copy link

Hello @ccordoba12! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 346:80: E501 line too long (85 > 79 characters)
Line 347:80: E501 line too long (105 > 79 characters)
Line 348:80: E501 line too long (105 > 79 characters)
Line 349:80: E501 line too long (95 > 79 characters)
Line 350:80: E501 line too long (96 > 79 characters)
Line 351:80: E501 line too long (94 > 79 characters)
Line 352:80: E501 line too long (95 > 79 characters)
Line 353:80: E501 line too long (92 > 79 characters)
Line 354:80: E501 line too long (91 > 79 characters)
Line 355:80: E501 line too long (103 > 79 characters)
Line 356:80: E501 line too long (112 > 79 characters)
Line 357:80: E501 line too long (94 > 79 characters)

@ccordoba12 ccordoba12 changed the title PR: Make style of "Print preview" dialog style follow the rest of Spyder PR: Make style of "Print preview" dialog follow the rest of Spyder Jul 30, 2022
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccordoba12 ! This LGTM 👍

@dalthviz dalthviz merged commit 24ca472 into spyder-ide:5.x Aug 1, 2022
dalthviz added a commit that referenced this pull request Aug 1, 2022
@ccordoba12 ccordoba12 deleted the print-dialog-style branch August 1, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants