-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add methods to simplify access to our config system to MainWindow
#18911
PR: Add methods to simplify access to our config system to MainWindow
#18911
Conversation
Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2022-08-05 18:24:37 UTC |
This is no longer used, so there's no need to keep it.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ccordoba12 ! Left a comment regarding the creation of a method to access shortcuts in a similar manner as to get and set configurations. Other than that this LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
MainWindow
MainWindow
Description of Changes
get_conf
/set_conf
methods to MainWindow in order to simplify how we access config options on that class.__init__
to be at the beginning of MainWindow (I think it's odd to have it in the middle of the class).Notes:
CONF
because it's cleaner and easier to read to have methods that call it behind the scenes.Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12