Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix focus when debugging cells #19066

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

impact27
Copy link
Contributor

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@ccordoba12 ccordoba12 changed the title PR: fix master tests - focus while debugging PR: Fix focus while debugging in master Aug 15, 2022
@ccordoba12
Copy link
Member

ccordoba12 commented Aug 16, 2022

Hey @impact27, thanks a lot for your help with this! I just checked in the latest 5.x and it seems this fix is also necessary there (i.e. debugcell is not preserving focus as it should). So, I'm going to move your PR to that branch and then merge it to make our tests pass in master again.

By the way, this is failing in master because the global debug toolbar now has only two actions and we're using the second one (i.e. Debug cell in master) in test_focus_to_editor.

@ccordoba12 ccordoba12 changed the title PR: Fix focus while debugging in master PR: Fix focus when running Debug cell Aug 16, 2022
@ccordoba12 ccordoba12 added this to the v5.3.3 milestone Aug 16, 2022
@ccordoba12 ccordoba12 changed the base branch from master to 5.x August 16, 2022 00:11
@ccordoba12 ccordoba12 changed the title PR: Fix focus when running Debug cell PR: Fix focus when debugging cells Aug 16, 2022
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27!

@ccordoba12 ccordoba12 merged commit 15e1e59 into spyder-ide:5.x Aug 16, 2022
ccordoba12 added a commit that referenced this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants