-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Several fixes related to the tabify plugins functionality #19163
PR: Several fixes related to the tabify plugins functionality #19163
Conversation
- This will work now for external and internal plugins. - Also improve logging messages about tabifying plugins.
Also move private methods to its own section
…ugins This was causing a crash at startup.
Seems like an issue on with the
Maybe with the changes made the |
I think I fixed that problem in my last commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ccordoba12 ! I left some comments regarding the code to register custom layouts (maybe could be worthy to be moved to the Layouts plugins), and also the possibility to addof the error
flag to the plugins get_plugin
method instead of using the mainwindow version. Other than that this LGTM 👍
@ccordoba12 I think that some tests fixtures that mock the MainWindow will need an update too (like for the Pylint plugin tests) |
Yep, I just did it. |
36148ef
to
60d9bb2
Compare
Description of Changes
TABIFY
class attribute for the Pylint and Profiler plugins.Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12