PR: Reload symbols when saving a file through the Save as menu entry (Outline)
#19360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: Comment last updated at 2022-09-09 18:48:22 UTC |
ccordoba12
force-pushed
the
issue-15517
branch
from
6b66ca8
to
0dba83c
Compare
dalthviz
reviewed
Sep 8, 2022
There was a problem hiding this comment.
Thanks @ccordoba12 ! Checked locally on WIndows and seems like the changes work there too 👍
Left some comments/questions regarding some code (a class and a test) that were removed here. Otherwise this LGTM 👍
ccordoba12
force-pushed
the
issue-15517
branch
from
0dba83c
to
e2b8c5c
Compare
ccordoba12
force-pushed
the
issue-15517
branch
from
e2b8c5c
to
b1d1b4b
Compare
dalthviz
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Symbols were pointing to the original file instead of the renamed one. This PR fixes that by deleting the current symbols and requesting them for the new file.
Before
After
Add a regression test for this.
Expand Outline tests to check that we can display special comments and cells.
Remove some dead code in the Outline and its tests.
Issue(s) Resolved
Fixes #15517
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12