Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Only autoformat on save if the file is a Python file (Editor) #19380

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Sep 9, 2022

Description of Changes

Autoformat is meant to be done only to Python files, trying do it on non Python files ends up in the launch of a never ending autoformat process

Issue(s) Resolved

Fixes #19344
Fixes #19248
Fixes #17577
Fixes #16166

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@dalthviz dalthviz added this to the v5.4.0 milestone Sep 9, 2022
@dalthviz dalthviz self-assigned this Sep 9, 2022
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small formatting suggestion for you @dalthviz, otherwise looks good to me.

spyder/plugins/editor/widgets/editor.py Outdated Show resolved Hide resolved
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit bed973b into spyder-ide:5.x Sep 9, 2022
ccordoba12 added a commit that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants