PR: Remove lambdas in Qt slots #19471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
changed the title
impact27
force-pushed
the
remove_labdas
branch
from
a0b5cbe
to
54b78da
Compare
ccordoba12
reviewed
Sep 17, 2022
| @@ -1053,6 +1053,7 @@ def update_margins(self, margin): | |||
| """ | |||
| self.get_widget().update_margins(margin) | |||
|
|
|||
| @Slot() | |||
There was a problem hiding this comment.
Please remove this (see below).
There was a problem hiding this comment.
I don't this this one should be removed, isn't it called from a signal?
There was a problem hiding this comment.
for example in the ipythonconsole plugin on_initialize
| @@ -113,7 +113,7 @@ def on_initialize(self): | |||
| self.create_action( | |||
| BreakpointsActions.ListBreakpoints, | |||
| _("List breakpoints"), | |||
| triggered=lambda: self.switch_to_plugin(), | |||
There was a problem hiding this comment.
Instead of calling this directly, please emit sig_switch_to_plugin_requested.
There was a problem hiding this comment.
That doesn't work because sig_switch_to_plugin_requested is connected to MainWindow.switch_to_plugin not to SpyderDockablePlugin.switch_to_plugin
|
Also, please rebase or merge with 5.x to get the fix to our Mac app on PR #19485. |
impact27
force-pushed
the
remove_labdas
branch
from
54b78da
to
619c58e
Compare
ccordoba12
approved these changes
Sep 20, 2022
ccordoba12
added a commit
that referenced
this pull request
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Remove unnecessary lambdas from signals
A lambda prevents qt from keeping a reference to the object, leading to:
Issue(s) Resolved
Fixes #19393
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: