PR: Fix showing pixelated SVG icons on high dpi screens #19526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
reviewed
Sep 21, 2022
There was a problem hiding this comment.
Thanks @ccordoba12 ! Checking this could be worthy to rename the ìcon0 for something like wrapping_icon or similar?
Other than that this LGTM 👍
|
Good point. I improved the variable names used in that method following your suggestion. |
dalthviz
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
SVG icons were looking like this in high dpi screens or when Spyder's
custom high DPI scalingis set to2.0in Preferences:Now they look like this
This regression was introduced in PR PR: Improve style and UX of new toolbar in collections viewer (Variable Explorer) #17811, when trying to set the disabled state of SVG icons.
Issue(s) Resolved
Fixes #19520.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: