-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Conform "find next" and "find previous" shortcuts to macOS standards #19795
Conversation
3881c6d
to
e8a2942
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help with this @mrclary!
"switch to plots" and "go to definition" shortcuts adopt "Ctrl+Shift+J" and "F3" respectively.
e8a2942
to
865de3d
Compare
@@ -424,7 +425,7 @@ | |||
'editor/move line up': "Alt+Up", | |||
'editor/move line down': "Alt+Down", | |||
'editor/go to new line': "Ctrl+Shift+Return", | |||
'editor/go to definition': "Ctrl+G", | |||
'editor/go to definition': "F3" if MAC else "Ctrl+G", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should change this shortcut to Ctrl+J
? I mean, I've heard that it's hard to access Fn
keys in Mac, so it could be worth considering this too.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My personal opinion is that "F3" is fine for a few reasons. We already use function keys for several things and macOS allows users to configure their function keys to be default. Most users were already using "F3" for "find next" which is a more utilized operation than "go to definition", so it won't be any less convenient, I think. Nevertheless, I usually use the "⌘+click" for "go to definition" anyway; I don't know how many users use that vs "⌘+G". I think the biggest pressure point, by far, for changing "find next" and "find previous" is simply consistency with most macOS applications, and not the convenience of the function key.
However, I don't use the plots pane for any of my workflows, so "F3" vs. "⌘+J" will have no real impact for me.
I'll let you make the call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I don't have a strong opinion either, so let's leave it like this and see what users think about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mrclary!
Description of Changes
find_replace
context.Issue(s) Resolved
Fixes #15437
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @mrclary