Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Conform "find next" and "find previous" shortcuts to macOS standards #19795

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Oct 12, 2022

Description of Changes

  • Changed "find next" to "Ctrl+G" and "find previous" to "Ctrl+Shift+G" for macOS in the find_replace context.
  • Changed "switch to plots" to "Shift+F3" and "go to definition" to "F3" for macOS.

Issue(s) Resolved

Fixes #15437

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @mrclary

@mrclary mrclary self-assigned this Oct 12, 2022
@mrclary mrclary added this to the v5.4.0 milestone Oct 12, 2022
@ccordoba12 ccordoba12 changed the title Conform "find next" and "find previous" shortcuts to macOS standards. PR: Conform "find next" and "find previous" shortcuts to macOS standards Oct 12, 2022
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help with this @mrclary!

spyder/config/main.py Outdated Show resolved Hide resolved
"switch to plots" and "go to definition" shortcuts adopt "Ctrl+Shift+J" and "F3" respectively.
@@ -424,7 +425,7 @@
'editor/move line up': "Alt+Up",
'editor/move line down': "Alt+Down",
'editor/go to new line': "Ctrl+Shift+Return",
'editor/go to definition': "Ctrl+G",
'editor/go to definition': "F3" if MAC else "Ctrl+G",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should change this shortcut to Ctrl+J? I mean, I've heard that it's hard to access Fn keys in Mac, so it could be worth considering this too.

What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My personal opinion is that "F3" is fine for a few reasons. We already use function keys for several things and macOS allows users to configure their function keys to be default. Most users were already using "F3" for "find next" which is a more utilized operation than "go to definition", so it won't be any less convenient, I think. Nevertheless, I usually use the "⌘+click" for "go to definition" anyway; I don't know how many users use that vs "⌘+G". I think the biggest pressure point, by far, for changing "find next" and "find previous" is simply consistency with most macOS applications, and not the convenience of the function key.

However, I don't use the plots pane for any of my workflows, so "F3" vs. "⌘+J" will have no real impact for me.

I'll let you make the call.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I don't have a strong opinion either, so let's leave it like this and see what users think about it.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary!

@ccordoba12 ccordoba12 merged commit 50ca5f7 into spyder-ide:5.x Oct 13, 2022
ccordoba12 added a commit that referenced this pull request Oct 13, 2022
@mrclary mrclary deleted the issue-15437-find-shortcut branch October 13, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants