PR: Fix bootstrap.py git subprocess call on Windows

[dalthviz]

Description of Changes

Missing Windows case to call git from subprocess from bootstrap.py

Issue(s) Resolved

Fixes #19865

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

[ccordoba12]

Looks good to me, thanks @dalthviz!

[mrclary]

@dalthviz @ccordoba12, will subprocess.run(["git", ...]) find git.cmd as well as git.exe on Windows?

I know that spyder.utils.programs.find_git has a lot of robust checks, but maybe we don't need to worry about that for bootstrap.py since this is primarily for developers who should have git installed properly on their system. So maybe "git" will work well enough for all platforms in this situation?

[ccordoba12]

will subprocess.run(["git", ...]) find git.cmd as well as git.exe on Windows?

Good point. I think it should work as long as shell=True on Windows.

[mrclary]

git.exe was found for me with shell=False

[dalthviz]

Thanks for the feedback @mrclary ! Checking I was able to change it to just git and without shell=True. Should I change this to just remove the "/usr/bin/env" so this will end up being for all the platforms:

        result = subprocess.run(
            ["git", "merge-base", "--fork-point", "master"]
        )

[ccordoba12]

+1 from me because it'd make the code simpler.

[mrclary]

+1 from me too.
Just the caveats that I mentioned: there may be instances where git is not installed, in which case the subprocess will fail and not master will always be written to boot_branch.txt and spyder will always be installed. Since this is primarily for developers, I think this edge case will be very rare.