Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Restore context menu on tabs (IPython console) #20000

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Nov 7, 2022

Description of Changes

  • This uses the new API to build it instead of passing the Options menu actions to the Tabs widget, as before.

  • That way we don't need to show the entire Options menu on the tabs context one. Instead, I decided to show only its first two sections, which are the most important ones.

    imagen

Issue(s) Resolved

Fixes #19991.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

This uses the new API to build it.
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccordoba12 ! Checked locally on Windows and seems like this is working 👍

@dalthviz dalthviz merged commit 4ead4aa into spyder-ide:5.x Nov 7, 2022
dalthviz added a commit that referenced this pull request Nov 7, 2022
@ccordoba12 ccordoba12 deleted the issue-19991 branch November 7, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants