Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Remove white dots on IPython console tabbar for Windows #20122

Merged
merged 3 commits into from
Nov 29, 2022

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Nov 27, 2022

Description of Changes

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@ccordoba12 ccordoba12 added this to the v5.4.1 milestone Nov 27, 2022
@ccordoba12 ccordoba12 self-assigned this Nov 27, 2022
@ccordoba12
Copy link
Member Author

@mrclary, could you check if those white pixels are present or not on Mac with this PR? Thanks!

@mrclary
Copy link
Contributor

mrclary commented Nov 28, 2022

@mrclary, could you check if those white pixels are present or not on Mac with this PR? Thanks!

macOS did not exhibit this issue before nor after this PR.
Screen Shot 2022-11-28 at 8 40 51 AM

Copy link
Contributor

@mrclary mrclary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @ccordoba12.

Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccordoba12 ! Checked locally but I still see a white dot on Windows:

imagen

Also, just in case, running with the latest 5.x I can see three dots:

imagen

@ccordoba12
Copy link
Member Author

Checked locally but I still see a white dot on Windows

Ok, that glitch is almost unnoticeable in my machine but it's clearly in yours, so I'll fix it too.

@ccordoba12
Copy link
Member Author

@dalthviz, I think I fixed the last white dot in my last commit, so please check again.

@dalthviz
Copy link
Member

@ccordoba12 still seeing it with the latest changes:

imagen

Also, playing a little bit with the IPython console dockwidget seems like the white dot dissapears when the tabs need to be collapsed and the tab buttons to horizontally scroll appear and take place on top of the tab list button:

tab_bar_points

@ccordoba12
Copy link
Member Author

@mrclary, could you recheck that you're not seeing white dots on Mac with this PR? My last commit could have changed things there (hopefully not, but you never know).

Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccordoba12 !

@mrclary
Copy link
Contributor

mrclary commented Nov 29, 2022

I confirm no white dots on macOS with latest commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants