Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update core dependencies for 5.4.1 #20277

Merged
merged 5 commits into from
Dec 29, 2022

Conversation

dalthviz
Copy link
Member

Description of Changes

  • Missing updates to core dependencies and subrepos
    • spyder-kernels to 2.4.1
    • python-lsp-server to 1.7.0
  • Remove restriction on Numpy being less than 1.23 (<1.23) for the Windows installer

Issue(s) Resolved

Fixes #20263

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

subrepo:
  subdir:   "external-deps/python-lsp-server"
  merged:   "2b3ac737a"
upstream:
  origin:   "https://github.com/python-lsp/python-lsp-server.git"
  branch:   "develop"
  commit:   "2b3ac737a"
git-subrepo:
  version:  "0.4.3"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "2f68596"
@dalthviz dalthviz added this to the v5.4.1 milestone Dec 29, 2022
@dalthviz dalthviz self-assigned this Dec 29, 2022
@dalthviz
Copy link
Member Author

dalthviz commented Dec 29, 2022

Note: Seems like the tests were failing due to https://conda-forge.org/docs/user/announcements.html#moving-to-conda-artifacts (you can see that there are no .tar.bz2 files generated for conda packages but .conda files at https://anaconda.org/conda-forge/spyder-kernels/files?version=2.4.1 and https://anaconda.org/conda-forge/python-lsp-server/files?version=1.7.0).

Also, seems like the cache key was being generated incorrectly since it was hashing requirements/*.txt files instead of requirements/*.yml files.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @dalthviz!

@dalthviz dalthviz merged commit 8696c7f into spyder-ide:5.x Dec 29, 2022
dalthviz added a commit that referenced this pull request Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants