PR: Remove Python 2 support (part I) #20366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot @oscargus for your help with this! It looks pretty good to me, so we'll try to merge it as soon as we release 5.4.2 so that it doesn't get outdated.
Let's leave that for another PR so we can have this one in quickly. |
|
@oscargus, I'm going to fix the small merge conflict that showed up here and merge your PR so it doesn't get outdated, like last time. |
ccordoba12
changed the title
- Restore missing import and remove unnecessary code. - Forcibly change line endings of a QDarkstyle file after trying to update its subrepo.
ccordoba12
force-pushed
the
py2removal
branch
from
d0e3bb7
to
166ab5d
Compare
ccordoba12
approved these changes
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Removing Python 2 support. I may continue with removing
py3compat.pycompletely, but will come back to that.Replaces #17173 (will really try to follow this through this time...)
Issue(s) Resolved
Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
oscargus/Oscar Gustafsson