PR: Fix segfault when closing files removed outside Spyder (Editor) #20586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
Thanks @ccordoba12 ! Checked locally on Windows and seems like is working 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This happened when you opened two or more files that exist in a branch (e.g.
spyder/plugins/debugger/api.pyandspyder/plugins/debugger/plugin.pyinmaster) one after the other, then switch to a branch where they are not available (e.g.5.x) and go back to Spyder.The crash happened after Spyder tried to close the second file, when you answer
Yesin the dialog below (you had to also answerYesfor the first removed file):Improve a couple of translation strings.
Ignore some revisions that changed line endings of
spyder/plugins/editor/widgets/editor.pyandspyder/plugins/editor/widgets/codeeditor.pybecause they brokegit blameof those files.Issue(s) Resolved
Fixes #18838.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: