Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Remove quotes from conda-activate.bat params and fix micromamba.exe detection (Installers) #20758

Merged
merged 2 commits into from
Jun 17, 2023

Conversation

dalthviz
Copy link
Member

Description of Changes

  • The installers use a bundled micromamba executable to activate environments but the logic to detect it in conda-activate.bat was not working (the activation was going through the conda option). This caused environments created with a prefix option to not be correctly activated showing the following message:
An error ocurred while starting the kernel
The following argument was not expected: <env path>
Run with ‑‑help for more information.
  • When doing a all users install on Windows the default directory for the installation is inside Program Files which has a space in its name. The space was causing problems to run the micromamba command to activate environments

Issue(s) Resolved

Fixes #16562

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@dalthviz
Copy link
Member Author

dalthviz commented May 22, 2023

Note: This could require to also update the micromamba executable version that is bundled with the installer

Edit: Checking with a version of the standalone installer with the latest version of micromamba (1.4.3), the per env environment variables work as expected

@dalthviz dalthviz changed the title [WIP] PR: Remove quotes from conda-activate.bat params and fix micromamba.exe detection (Installer) PR: Remove quotes from conda-activate.bat params and fix micromamba.exe detection (Installer) Jun 16, 2023
@dalthviz dalthviz requested a review from ccordoba12 June 16, 2023 22:56
@ccordoba12 ccordoba12 changed the title PR: Remove quotes from conda-activate.bat params and fix micromamba.exe detection (Installer) PR: Remove quotes from conda-activate.bat params and fix micromamba.exe detection (Installers) Jun 17, 2023
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit 1f9223e into spyder-ide:5.x Jun 17, 2023
24 checks passed
ccordoba12 added a commit that referenced this pull request Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants