Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Change reporting of macOS system from Darwin to macOS and include machine type #20823

Merged
merged 2 commits into from
Apr 27, 2023

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Apr 14, 2023

Description of Changes

In About widget, changed system info reporting for macOS from "Darwin" to "macOS" with appropriately changed release designation.
Also added machine type ('arm64', 'x86_64', 'AMD64', etc) to the system info for all platforms.

In the system info for issue reporting (and "Copy version info" of About widget), operating system value is replaced with the value of platform.platform.

"macOS 13.3" is more meaningful than "Darwin 22.4.0" to users, issue reporters, and developers. Additionally, inclusion of machine type may eliminate the need for developers to ask issue reporters "Is your machine Intel or M1?".

New "About" widget text

Screenshot 2023-04-17 at 8 40 32 AM

New Issue text

  • Spyder version: 6.0.0.dev0 47a906d (standalone)
  • Python version: 3.9.16 64-bit
  • Qt version: 5.15.6
  • PyQt5 version: 5.15.7
  • Operating System: macOS-13.3-x86_64-i386-64bit

@mrclary mrclary self-assigned this Apr 14, 2023
@mrclary
Copy link
Contributor Author

mrclary commented Apr 14, 2023

@spyder-ide/core-developers, what do you think about this PR?

@dalthviz
Copy link
Member

Sounds like a good idea @mrclary ! Maybe is worthy to add this change in 5.x too?

@mrclary
Copy link
Contributor Author

mrclary commented Apr 14, 2023

Sounds like a good idea @mrclary ! Maybe is worthy to add this change in 5.x too?

I have no problem with that, depending on what others have to say.

@mrclary
Copy link
Contributor Author

mrclary commented Apr 17, 2023

@spyder-ide/core-developers, do you think this should be moved to 5.x?

@ccordoba12
Copy link
Member

ccordoba12 commented Apr 17, 2023

+1 from me. For that (if others think that's ok), please use following commands:

git checkout mac-version
git rebase --onto 5.x master mac-version
git push -f origin mac-version

@mrclary mrclary changed the base branch from master to 5.x April 18, 2023 00:42
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @mrclary!

@ccordoba12 ccordoba12 added this to the v5.4.4 milestone Apr 18, 2023
@mrclary
Copy link
Contributor Author

mrclary commented Apr 18, 2023

@dalthviz, did you want to say anything or are you good?

Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary ! Checked locally the changes on Windows and LGTM 👍

As a suggestion it could be nice to have a test that runs on macOS, Linux and Windows checking the dialog since I think the only test that we have for the dialog is the one at the end of the file which only is run on Linux 🤔

Anyhow, not something to prevent this from being merged 👍

@ccordoba12
Copy link
Member

Let's merge this one.

@ccordoba12 ccordoba12 merged commit 51b1c0b into spyder-ide:5.x Apr 27, 2023
ccordoba12 added a commit that referenced this pull request Apr 27, 2023
@mrclary mrclary deleted the mac-version branch April 27, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants