Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Catch PermissionsError when trying to get applications executables (Files) #20948

Merged
merged 2 commits into from
May 22, 2023

Conversation

dalthviz
Copy link
Member

Description of Changes

When running from a non-admin account on Windows the applications executables discovery can fail with a PermissionsError. Catch the error an fallback to an empty applications list.

Issue(s) Resolved

Fixes #20907

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@dalthviz dalthviz added this to the v5.4.4 milestone May 19, 2023
@dalthviz dalthviz self-assigned this May 19, 2023
@dalthviz dalthviz changed the title PR: Catch PermissionsError when trying to get applications executables on Windows (Files) PR: Catch PermissionsError when trying to get applications executables (Files) May 19, 2023
@dalthviz dalthviz requested a review from ccordoba12 May 19, 2023 22:41
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz! I simply left a clarifying comment as a suggestion.

Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
@dalthviz dalthviz requested a review from ccordoba12 May 22, 2023 17:39
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit 91e496f into spyder-ide:5.x May 22, 2023
24 checks passed
ccordoba12 added a commit that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants