PR: Fix interface language auto-configuration #21451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sthibaul
force-pushed
the
master
branch
2 times, most recently
from
644b0c3
to
32f72bd
Compare
|
(I'd argue that this is a very problematic bug, when we are trying to convince our thousands of students that yes, spyder is a good IDE for programming in python) |
ccordoba12
reviewed
Oct 26, 2023
There was a problem hiding this comment.
Hey @sthibaul, thanks a lot for your contribution! We were not aware of it this problem (we always test Spyder in English) and it's even better that you've provided a fix for it too!
I left a small comment below, the rest looks good to me. And we'll include your fix in our next version (5.5.0), to be released next week.
|
Note: I'm marking this for Spyder 6 because you did your pull request against our |
ccordoba12
changed the title
When LANGUAGE_CODES is missing a case, get_available_translations() would be returning just ['en'], which breaks language autoconfiguration for all the cases that are indeed in LANGUAGE_CODES. Better annoy only developers about this and return the languages which are indeed in LANGUAGE_CODES, so that language autoconfiguration does work for those.
Addition to LANGUAGE_CODES and DISABLED_LANGUAGES was missed.
ccordoba12
approved these changes
Oct 26, 2023
ccordoba12
changed the title
ccordoba12
added a commit
to ccordoba12/spyder
that referenced
this pull request
Oct 26, 2023
ccordoba12
added a commit
to ccordoba12/spyder
that referenced
this pull request
Oct 28, 2023
ccordoba12
added a commit
that referenced
this pull request
Oct 28, 2023
PR: Backport PR #21451 (Fix interface language auto-configuration)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The autoconfiguration of the language is currently completely broken: when starting spyder on a e.g. french-installed OS, spyder still displays english by default.
This is because
spyder/config/base.py'sget_available_translations()currently always return['en'], becauseLANGUAGE_CODESis currently missing a few cases ofspyder/locale/. One can of course just add the missing cases, but better just at least support autoconfiguring the cases which are inLANGUAGE_CODESrather than breaking them all (Except for developers, which do need to take notice of this).Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
Samuel Thibault