Open configuration file with utf-8 encoding on Windows and Python 2 #2219
Conversation
| if osp.isfile(fname): | ||
| try: | ||
| with codecs.open(fname, encoding='utf-8') as configfile: | ||
| self.readfp(configfile) |
There was a problem hiding this comment.
Why did you decide to use readfp instead of read here?
There was a problem hiding this comment.
read() expects filename and does file open itself, readfp() expects open file handle
There was a problem hiding this comment.
Yes, I thought that was the case. So codecs.open returns the file handle?
|
@vasily-smirnov, thanks a lot your contribution! Let's hope this finishes all the problems we've had with non-ascii accounts on Windows :-) I just have a minor (clarification) comment before merging |
ccordoba12
changed the title
|
@vasily-smirnov, I think changing |
|
done as you suggested, not tested |
|
I tested it and unfortunately is not working. Sorry for making you waste your time, but please revert to use |
|
no problem, done, thanks for testing |
Open configuration file with utf-8 encoding on Windows and Python 2
|
Thanks a lot for your work. |
|
de nada! I like spyder very much :-) |
|
Muchas gracias ;-) |
This change is related to issue 2081 for the case when user home directory contains non-ascii characters and Spyder reads/writes INI file into that directory.
This change does NOT resolve the issue 2081 (there are cases with non-ascii working directory and plus some dependencies out of Spyder codebase).
This change seems failsafe.
Fixes #2081