New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Create a separate window when undocking plugins #3824
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
6f45e71
New behavior when undoking Editor window.
dalthviz ece67e1
Fixed misspell.
dalthviz 238ffd6
Added undock function. Added restriction to create more than one edit…
dalthviz 71ec0aa
Fixed code style problem.
dalthviz 6769d6d
Fixed code style problem.
dalthviz ecac519
Fixed problem with attribute create_new_window of the EditorStack.
dalthviz 5dad62d
Moves undock method to the Editor.
dalthviz e679c2d
Initial implementation to undock as a window.
dalthviz aa36f3c
Improvements and some plugins with all the functionality.
dalthviz aaa59e8
Adds undock action to the Variable Explorer and the Internal Console.
dalthviz 21cee40
Adds a validation for the parent.
dalthviz b668163
Initial base. Some plugins working.
dalthviz d2589cd
Merge branch 'master' into fixes_issue_3790_2
dalthviz d7db783
Add more plugins.
dalthviz a9da3f1
Fix variable explorer actions.
dalthviz 160adca
Fix explorer.
dalthviz 9f134f8
Fix code style issues.
dalthviz b899227
Use tool button from the plugin in the IPython console.
dalthviz c37f541
Merge branch 'master' into fixes_issue_3790_2
dalthviz 072c4a3
Fix unabled actions variableexplorer.
dalthviz 9fae0b0
Merge branch 'fixes_issue_3790_2' of https://github.com/dalthviz/spyd…
dalthviz 43a55ad
Fix code style issues.
dalthviz 5ebbc84
Change None for MENU_SEPARATOR, revert some unnecessary changes.
dalthviz f9168c4
Merge branch 'master' into fixes_issue_3790_2
dalthviz c186de6
Change 'Undock the plugin' to 'Undock'. Change 'menu' for 'options_me…
dalthviz 3437f75
Fix tests.
dalthviz File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(A comment out of the scope of this PR)
We could consider moving
initialize_plugin
plugin to a meta class (or__init_subclass__
in python3) so plugins shouldn't have to add it. I'll open a new issue about this for further discussing (there's also other things that we could improve using a metaclass)