Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update translation jp #3850

Closed
wants to merge 2 commits into from
Closed

PR: Update translation jp #3850

wants to merge 2 commits into from

Conversation

sohnishi
Copy link
Contributor

I'm very sorry for missing @ccordoba12 's announce #3430 about translations.
I updated the Japanese translation for current version.
Please accept my apology and update files.

Or I wonder I should wait for the next major release.

@ccordoba12
Copy link
Member

@sohnishi, thanks a lot for updating the Japanese translations! However, we need you to redo this pull request against the 3.x branch (instead of master) so we can merge it for 3.1.

For that you need to follow these steps:

  1. git checkout 3.x (to place yourself in 3.x branch of your fork).
  2. git checkout -b jp_update_1 (to create a branch for you to update the translations)
  3. Move the files in this pull request to that branch
  4. Commit and push again to Github.
  5. Create a new pull request with your changes.

Thanks for your help :-)

@sohnishi
Copy link
Contributor Author

Thank you. I will try this backport work soon.

@ccordoba12
Copy link
Member

Thanks @sohnishi! Closing this one for now then :-)

@ccordoba12 ccordoba12 closed this Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants