Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Catch any error when creating stderr files in the IPython console #6305

Merged
merged 2 commits into from Jan 27, 2018

Conversation

dalthviz
Copy link
Member

Fixes #6267

@dalthviz dalthviz added this to the v3.2.7 milestone Jan 26, 2018
@dalthviz dalthviz self-assigned this Jan 26, 2018
@ccordoba12 ccordoba12 changed the title Add catch to any error when connecting client to kernel in the IPython Console PR: Add catch to any error when connecting client to kernel in the IPython Console Jan 27, 2018
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dalthviz, this is not the right place to catch the error reported on issue #6267. It's this line:

https://github.com/spyder-ide/spyder/blob/master/spyder/plugins/ipythonconsole.py#L1497

Please put a try/except around that line, and in the except part stderr = None.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz!

@ccordoba12 ccordoba12 changed the title PR: Add catch to any error when connecting client to kernel in the IPython Console PR: Catch any error when creating stderr files in the IPython console Jan 27, 2018
@ccordoba12 ccordoba12 merged commit fd54df3 into spyder-ide:3.x Jan 27, 2018
ccordoba12 added a commit that referenced this pull request Jan 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants