Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Upgrade all links to use HTTPS where available, and fix link targets when broken/redirected #7611

Merged
merged 2 commits into from Aug 4, 2018

Conversation

CAM-Gerlach
Copy link
Member

Pull Request Checklist

  • Read and followed this repo's Contributing Guidelines
  • Based your PR on the latest version of the correct branch (master or 3.x)
  • Followed PEP8 for code style
  • Ensured your pull request hasn't eliminated unrelated blank lines/spaces,
    modified the spyder/defaults directory, or added new icons/assets
  • Described your changes and the motivation for them below

Description of Changes

Upgrades all URLs to use HTTPS where available, to follow modern best practices, being conservative about skipping any that could potentially have side effects (i.e. any in tests, functional code, non-standard URLs, those not user-accessible or in a non-parsed string, etc;). All links were manually tested before and after conversion, and a number of broken, outdated or redirected ones were updated where possible (or, in rare cases where no valid copy existed online and the link was merely for reference rather than a citation or something functional, removed).

@pep8speaks
Copy link

Hello @CAM-Gerlach! Thanks for submitting the PR.

Line 35:14: E221 multiple spaces before operator

@CAM-Gerlach CAM-Gerlach changed the title PR: Update all links to use HTTPS where available, and fix link targets when broken/redirected PR: Upgrade all links to use HTTPS where available, and fix link targets when broken/redirected Aug 3, 2018
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, thanks @CAM-Gerlach!

I only have one question: did you verify that all links you changed work in https?

@CAM-Gerlach
Copy link
Member Author

CAM-Gerlach commented Aug 3, 2018

@ccordoba12 Yup!

All links were manually tested before and after conversion

As also mentioned, I didn't touch

any that could potentially have side effects (i.e. any in tests, functional code, non-standard URLs, those not user-accessible or in a non-parsed string, etc;)

along with XML schema/namespaces and the like.

@ccordoba12 ccordoba12 merged commit a5a9cfe into spyder-ide:3.x Aug 4, 2018
ccordoba12 added a commit that referenced this pull request Aug 4, 2018
@CAM-Gerlach CAM-Gerlach deleted the update-links-https branch September 12, 2018 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants