PR: Remove gettext scripts separated into their own repo #7791
+0
−151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAM-Gerlach
changed the title
|
@ccordoba12 Should be ready to go on my end, now that spyder-ide/gettext-helpers#1 is done. |
ccordoba12
approved these changes
Aug 31, 2018
|
Thanks @CAM-Gerlach! Let's wait for @jnsebgosselin to fix our tests before merging this one. |
|
I'm in the process of rebasing #7790, this should be done shortly. |
|
Thanks @ccordoba12 and @jnsebgosselin ; standing by to rebase once that's done. |
|
My PR addresses only part of the problem it seems. There is another test that needs fixing : |
|
@jnsebgosselin I've seen that one segfault seemingly randomly maybe 1/10 times on Travis in the past... |
|
Failures in Travis were already fixed. |
|
Thanks @ccordoba12 ! |
ccordoba12
added a commit
that referenced
this pull request
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
modified the
spyder/defaultsdirectory, or added new icons/assetsDescription of Changes
Removed the gettext_*.py scripts in the root, since they've been moved to their own repo. Marked [WiP] so as not to merge until that repo is set up properly.