PR: Split "test_mainwindow.test_help" and skip tests on Windows CI because they are timing out. #7792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the "get help" feature in the IPython console and the Editor independently, otherwise, it's not possible to know which one is timing out on AppVeyor.
ccordoba12
changed the title
|
Tests are failing in Travis in the exact same point, so it seems you have found another error due to this. |
|
Ok, I see you're addressing that in PR #7790. |
ccordoba12
approved these changes
Aug 31, 2018
|
Failures in Travis were already fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
It seems that tests related to the LSP are failing on AppVeyor with this error:
This PR proposes to skip the problematic tests on Windows CI. Note that the tests are passing locally on my Windows 10 laptop.
Also this PR proposes to split the
test_mainwindow.test_helpin two so thatHelpis tested independently when called from the Editor or from the IPython console. Otherwise, it is not possible to know if the test is timing out because of the action made in the Editor or in the IPython console.Unfortunately, after the split, I found out that both tests were timing out on AppVeyor, so they had to be skipped. Still, I think splitting the test in two is an improvement, so I'm proposing it here anyway.
Issue(s) Resolved
This PR will allow the tests on Appveyor to pass for the following three PR:
PR #7790
PR #7789
PR #7768