PR: Add some color schemes from Eclipse

[PanderMusubi]

Description of Changes

See issue

Issue(s) Resolved

Fixes #8371

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: PanderMusubi

[pep8speaks]

Hello @PanderMusubi! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-06-20 15:38:24 UTC

[ccordoba12]

Thanks for your contribution!

@CAM-Gerlach, could you review this one? Thanks!

[PanderMusubi]

@CAM-Gerlach there will be one more commit, please review it only when that is in.

[PanderMusubi]

@CAM-Gerlach latest commit is there. :)

[CAM-Gerlach]

@CAM-Gerlach @ccordoba12 Okay, thanks—looking at it now.

[CAM-Gerlach]

Thanks!

I tested each of them, and they all seem to work and display fine. However, one thing—we should be consistent about how we capitalize the names, so please make all of them Title Case—you're missing a couple.

Besides that, I don't see a problem with it, other than the theme list starting to grow to a bit of an unwieldy length—if/when we merge this, it would be nice to follow up with a PR that provides some clear indication of whether a theme in the list is light or dark, so users can see at a glance—of course, that would be a separate PR.

[PanderMusubi]

@CAM-Gerlach see latest commit.

[CAM-Gerlach]

Thanks @PanderMusubi ! This pretty much looks good to me now.

You're going to need to rebase on the latest master, since we also just updated the Spyder Dark color scheme which resulted in a conflict with yours.

While you're at it, could you fixup (via e.g, interactive rebase) your second and fourth commits into your first and third, and edit the latter's commit message to conform to the universal imperative tense and capatilized convention ("Add color schemes converted from Eclipse color themes", "Optimize and add current cell colors to new Eclipse color schemes")? Thanks.

[CAM-Gerlach]

LGTM, thanks! Just needs a merge with master now to resolve the expected conflict from modifying the Spyder Dark theme.

[CAM-Gerlach]

@PanderMusubi Hey, if you can merge (or rebase) with master to fix the conflict with the default theme being changed, that would be great and this should be ready to go, pending @ccordoba12 's review. Thanks!

[ccordoba12]

I need to see an screenshot per each color scheme added. I don't know if I'll agree to all of them to be included, hence the screenshots.

[CAM-Gerlach]

Okay, that's going to be a lot of screenshots, heh. I can do it a little later.

[PanderMusubi]

For this and future PRs, please use https://github.com/PanderMusubi/convert-theme-to-scheme which will generate the Python code to include. It also generated an INI file to easily test the schemes. I will leave the squashing and rebasing to you. If you need me to help with convert-theme-to-scheme, please let me know.

[goanpeca]

I will update the PR and post the screenshots

[CAM-Gerlach]

Thanks @goanpeca ! I had started going through them, but with the very long lag to switch syntax schemes on my machine it ended up getting bumped for other priorities.

[steff456]

Black Pastel

Frontenddev

Gedit Original Oblivion

Havenkark

---

Inkpot

---

Minimal

---

Mr

---

NightLionAptana Theme

---

Notepad++ Like

---

Oblivion

---

** Obsidian**

---

Pastel

---

RecognEyes

---

Retta

---

Roboticket

---

Schuss

---

Sublime Text Monokai Extended

---

Sublime Text 2

---

Sunburst

---

Tango

---

Vibrant Ink

---

Wombat

[goanpeca]

@ccordoba12 we could add these styles as a plugin that adds them?

It might also make sense to not keep the styles on the spyder.ini anymore.

[ccordoba12]

we could add these styles as a plugin that adds them?

Not right now.

It might also make sense to not keep the styles on the spyder.ini anymore.

Good point @goanpeca!

@steff456, please move the entire appearance section as a dict to a new file called spyder/config/appearance.py with the name APPEARANCE, and import it from there to spyder/config/main.py.

[ccordoba12]

I'll take a look this weekend at what schemes should stay and be removed.

@goanpeca, any particular preferences?

[goanpeca]

I like the dark ones :-) pastel

[ccordoba12]

Ok, I think we should remove these themes:

• Black pastel (too low contrast)
• Frontenddev (too similar to our Emacs theme)
• Gedit Original Oblivion (too low contrast)
• Havenkark (too low contrast and I don't like the select line color)
• Mr (too similar to IDLE)
• RecognEyes (too similar to our theme)
• Schuss (too low contrast)
• Sublime Text 2 (I don't like the colors and we already have Monokai)
• Sunburst (too low contrast)
• Tango (too low contrast)
• Wombat (I don't like the colors)

---

@spyder-ide/core-developers, @spyder-ide/junior-developers, what do you think?

[ccordoba12]

@steff456, please rename Notepad++ Like to Notepad++.

[ccordoba12]

@steff456, I just noticed that none of the new themes provides a currentcell color. Please add one by using a color picker and getting a lighter version of the background color for the dark themes. For the light themes you can use the light yellow used in the Spyder theme or the pink color used in the IDLE theme (depending on which one suits the theme better).

[goanpeca]

@ccordoba12 to prevent this in the future I suggest we add a simple test that will iterate and check that:

• All the expected keys are found for every theme
• All the values are correct color values (or True or False)

Thoughts?

[ccordoba12]

The key was there, the problem was that the color was not defined to something useful.

[goanpeca]

Ah ok got it

[ccordoba12]

@steff456, last comments about the themes we chose:

• Notepad++: currentline cannot be distinguished from currentcell.
• Pastel: The difference between currentline and currentcell is very small. Please make the difference clearer.
• Roboticket: currentline cannot be distinguished from currentcell.

[ccordoba12]

Thanks @steff456 for your help to finish this one and @PanderMusubi for you initial submission.