Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Restore underlining errors and warnings in the Editor #9597

Merged
merged 3 commits into from Jun 18, 2019

Conversation

steff456
Copy link
Member

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Restore underlining errors and warning in the editor from PyLS

I'm not sure if we should use wave underline, it is not showing as much as expected.
image

However the single line underline is more visible,
image

Issue(s) Resolved

Fixes #9472

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: steff456

@pep8speaks
Copy link

pep8speaks commented Jun 18, 2019

Hello @steff456! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1473:25: E128 continuation line under-indented for visual indent

Comment last updated at 2019-06-18 15:47:07 UTC

@ccordoba12 ccordoba12 added this to the v4.0beta3 milestone Jun 18, 2019
@ccordoba12
Copy link
Member

I'd say we should go with a single underline instead of the wavy one.

@goanpeca, what do you say?

@goanpeca
Copy link
Member

Sure @ccordoba12 let's try that one out

@ccordoba12
Copy link
Member

@steff456, is this ready to go?

@steff456
Copy link
Member Author

@steff456, is this ready to go?

I will put the single underline and it will be ready to go

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @steff456!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore underlining errors and warnings in the Editor
4 participants