Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update Jedi asset for its 0.18 version #4

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

ccordoba12
Copy link
Member

Since we now support that version (thanks to spyder-ide/spyder#15878), we needed to update the corresponding asset here.

I can confirm this fixes all functionality related to Jedi in Spyder 5.1

@ccordoba12 ccordoba12 self-assigned this Aug 3, 2021
@dalthviz
Copy link
Member

dalthviz commented Aug 4, 2021

@ccordoba12 checked this patch by installing Spyder with the current installer available and overwriting the __main__.py file in the jedi package with the one here but even with that I don't see the outline being populated. Is that something this update aims to fix or is different? Maybe I should test in a different way?

@ccordoba12
Copy link
Member Author

Sorry, I forgot to mention that you need to use the installer on PR spyder-ide/spyder#16130 because it fixes the very serious spyder-ide/spyder#16117.

Although the Windows installer was not affected by it, still all 5.1.0 packages had their plugins messed up due to that.

Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ccordoba12 LGTM, after using the right installer it worked. Will do the release and the PR to update the assets version in the main repo then 👍

@dalthviz dalthviz merged commit e2cdb8f into spyder-ide:main Aug 4, 2021
@ccordoba12 ccordoba12 deleted the update-jedi branch August 4, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants