Add Makefile.toml #497
Merged
Add Makefile.toml #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 31, 2023 21:39
- adding makefile.toml as an alternative to Makefile - better support for windows dev experience
|
Sorry for the delay @JinKim7 , looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new file makefile.toml as an alternative to Makefile.
The next step is properly complete and test on Windows, but wanted to keep this as an intro PR that at least works on macOS.
Commands to Test
cargo install cargo-makecargo make setupcargo make runcargo make run-clientcargo make run-backendNote: will work on the plugin and bundling commands in a future PR.
Here is a separate PR that will update the dev documentations: spyglass-search/docs.spyglass.fyi#6