Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: lack of asterisk * options in class Hotstring #218

Closed
zzsimplezz opened this issue Jul 9, 2023 · 3 comments · Fixed by #219
Closed

Bug: lack of asterisk * options in class Hotstring #218

zzsimplezz opened this issue Jul 9, 2023 · 3 comments · Fixed by #219
Labels
bug Something isn't working

Comments

@zzsimplezz
Copy link

In AHK, you can use asterisk * for trigger hotstring without ending character.

Currently the regex assert in class Hotstring lacks it.

the regex _validate method in class Hotstring:

(\?|C|C1|K\d+|O|P\d+|S[IPE]|T|Z)+

it should add "*" to work:

(\?|C|C1|K\d+|O|P\d+|S[IPE]|T|Z|\*)+

thank you for your lib. 😄
@spyoungtech spyoungtech added the bug Something isn't working label Jul 10, 2023
@spyoungtech
Copy link
Owner

Yep, that seems like an oversight. Will add the fix in an upcoming release.

@spyoungtech spyoungtech mentioned this issue Jul 10, 2023
Merged
spyoungtech added a commit that referenced this issue Jul 10, 2023
@spyoungtech
Merge pull request #219 from spyoungtech/gh-218
9439105 
support asterisk in hotkey options
@spyoungtech
Copy link
Owner

This has been merged and will be released in the upcoming 1.2.0 release.

@spyoungtech
Copy link
Owner

This has been released in 1.2.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support asterisk in hotkey options spyoungtech/ahk
2 participants
@spyoungtech @zzsimplezz