Add fixme comments to read(u)int64.

sq · Jun 19, 2012 · b76bead · b76bead
1 parent 0152e3b
commit b76bead
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/Libraries/JSIL.IO.js b/Libraries/JSIL.IO.js
@@ -645,6 +645,8 @@ JSIL.ImplementExternals("System.IO.BinaryReader", function ($) {
   $.Method({Static:false, Public:true }, "ReadInt64", 
     (new JSIL.MethodSignature($.Int64, [], [])), 
     function ReadInt64 () {
+      // FIXME: Does this work right for negative numbers or does 53-bit rounding kill it?
+      // FIXME: Generate warnings for values out of 53-bit range.
       var value = this.ReadUInt64();
       if (value > System.Int64.MaxValue)
         return value - 18446744073709551616;
@@ -706,6 +708,7 @@ JSIL.ImplementExternals("System.IO.BinaryReader", function ($) {
   $.Method({Static:false, Public:true }, "ReadUInt64", 
     (new JSIL.MethodSignature($.UInt64, [], [])), 
     function ReadUInt64 () {
+      // FIXME: Generate warnings for values out of 53-bit range.
       var low1 = this.m_stream.ReadByte();
       var low2 = this.m_stream.ReadByte();
       var low3 = this.m_stream.ReadByte();