This repository has been archived by the owner on Aug 24, 2022. It is now read-only.
Method signatures cache improvements #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hidden under CodeGenerator.PreferLocalCacheForGenericMethodSignatures and CodeGenerator.PreferLocalCacheForGenericInterfaceMethodSignatures settings. Implemented caching one method signature per signature versus per method (sq#896), hidden under CodeGenerator.CacheOneMethodSignaturePerMethod setting. Renamed setting and inverted setting: CodeGenerator.CacheGenericMethodSignatures -> CodeGenerator.DisableGenericSignaturesLocalCache
…n with default settings.
…e each generic only once).
|
Cool, thanks for doing this. Sounds like a big improvement. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here i implemented caching of open generic signatures (#970) and preserving only one signature cache per signature (896).
Both features are hidden under default settings.
(1) To enable global caching for open generic signatures user should change config:
CodeGenerator.PreferLocalCacheForGenericMethodSignatures=false
(2) To enable global caching for open generic interface method signatures user should change config:
CodeGenerator.PreferLocalCacheForGenericInterfaceMethodSignatures=false
(3) To enable storing only one method signature cache per signature:
CodeGenerator.CacheOneMethodSignaturePerMethod=false
I will still work more on method calls performance improvements, as all suggested option could either increase or decrease execution time dependent on usage scenario.
For my project I get about 20% performance improvement with
CodeGenerator.PreferLocalCacheForGenericMethodSignatures=false. All other settings actually have not changed measured performance of my application.