Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .NET 8 #26

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Add support for .NET 8 #26

merged 4 commits into from
Dec 1, 2023

Conversation

LeaFrock
Copy link
Contributor

@LeaFrock LeaFrock commented Nov 19, 2023

All tests passed on my local machine (Win 11).

@aradalvand
Copy link
Collaborator

@LeaFrock Thank you for the PR! Could you please take a look at my review above?

@LeaFrock
Copy link
Contributor Author

LeaFrock commented Nov 21, 2023

@aradalvand My pleasure. But where is your review? I do not see it currently.

src/Sqids/SqidsEncoder.cs Show resolved Hide resolved
src/Sqids/SqidsEncoder.cs Show resolved Hide resolved
src/Sqids/SqidsEncoder.cs Outdated Show resolved Hide resolved
@aradalvand
Copy link
Collaborator

aradalvand commented Nov 21, 2023

@LeaFrock Oops, my bad, I forgot to click on the "submit review" button 😅 Sorry!
You should now be able to see the review.

@aradalvand aradalvand merged commit ff3505c into sqids:main Dec 1, 2023
1 check passed
@aradalvand
Copy link
Collaborator

aradalvand commented Dec 1, 2023

Thank you @LeaFrock for the contribution! I have just released v3.1.0 and it's also on NuGet now; thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants